olution #790
olution #790
Conversation
app/main.py
Outdated
| elif isinstance(other, (int, float)): | ||
| return Distance(self.km + other) | ||
|
|
||
| def __iadd__(self, other: "Distance") -> "Distance": |
There was a problem hiding this comment.
other can be of type int or float as well. fix anything that needs correction
app/main.py
Outdated
| def __lt__(self, other: "Distance") -> bool: | ||
| if isinstance(other, Distance): | ||
| return self.km < other.km | ||
| elif isinstance(other, (int, float)): |
There was a problem hiding this comment.
You can simplify the code by removing the elif statement
There was a problem hiding this comment.
якщо я видаляю та додаю анотації int та float в мене не проходят тести
There was a problem hiding this comment.
def __lt__(self, other: int | float) -> bool:
return self.km < other.km
типу такого?
There was a problem hiding this comment.
simply remove the whole elif statement. if other is not an instanсe of the Distance class you can straight return self.km < other
app/main.py
Outdated
| def __lt__(self, other: "Distance") -> bool: | ||
| if isinstance(other, Distance): | ||
| return self.km < other.km | ||
| elif isinstance(other, (int, float)): |
There was a problem hiding this comment.
simply remove the whole elif statement. if other is not an instanсe of the Distance class you can straight return self.km < other
app/main.py
Outdated
| def __lt__(self, other: "Distance") -> bool: | ||
| if isinstance(other, Distance): | ||
| return self.km < other.km | ||
| elif isinstance(other, (int, float)): |
There was a problem hiding this comment.
| elif isinstance(other, (int, float)): |
app/main.py
Outdated
| if isinstance(other, Distance): | ||
| return self.km < other.km | ||
| elif isinstance(other, (int, float)): | ||
| return self.km < other |
There was a problem hiding this comment.
| return self.km < other | |
| return self.km < other |
app/main.py
Outdated
| elif isinstance(other, (int, float)): | ||
| return Distance(self.km + other) | ||
|
|
||
| def __iadd__(self, other: "Distance") -> "Distance": |
app/main.py
Outdated
| def __repr__(self) -> str: | ||
| return f"Distance(km={self.km})" | ||
|
|
||
| def __add__(self, other: None) -> "Distance": |
There was a problem hiding this comment.
Indicate the correct type annotation for other, it could be either int, float, or an instance of the Distance class. Besides that, do not place Distance inside of "", and omit using quotes in the type annotation. In case you face errors, you could add from __future__ import annotations to your file. Revise the type annotation throughout all your code to be representative enough.
No description provided.