-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
olution #790
base: master
Are you sure you want to change the base?
olution #790
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,3 +1,60 @@ | ||||||
class Distance: | ||||||
# Write your code here | ||||||
pass | ||||||
def __init__(self, km: float) -> None: | ||||||
self.km = km | ||||||
|
||||||
def __str__(self) -> str: | ||||||
return f"Distance: {self.km} kilometers." | ||||||
|
||||||
def __repr__(self) -> str: | ||||||
return f"Distance(km={self.km})" | ||||||
|
||||||
def __add__(self, other: "Distance") -> "Distance": | ||||||
if isinstance(other, Distance): | ||||||
return Distance(self.km + other.km) | ||||||
elif isinstance(other, (int, float)): | ||||||
return Distance(self.km + other) | ||||||
|
||||||
def __iadd__(self, other: "Distance") -> "Distance": | ||||||
if isinstance(other, Distance): | ||||||
self.km += other.km | ||||||
elif isinstance(other, (int, float)): | ||||||
self.km += other | ||||||
return self | ||||||
|
||||||
def __mul__(self, other: "Distance") -> "Distance": | ||||||
if isinstance(other, (int, float)): | ||||||
return Distance(self.km * other) | ||||||
|
||||||
def __truediv__(self, other: "Distance") -> "Distance": | ||||||
if isinstance(other, (int, float)): | ||||||
return Distance(round(self.km / other, 2)) | ||||||
|
||||||
def __lt__(self, other: "Distance") -> bool: | ||||||
if isinstance(other, Distance): | ||||||
return self.km < other.km | ||||||
elif isinstance(other, (int, float)): | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can simplify the code by removing the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. якщо я видаляю та додаю анотації int та float в мене не проходят тести There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. simply remove the whole elif statement. if other is not an instanсe of the Distance class you can straight return self.km < other There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
return self.km < other | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
def __gt__(self, other: "Distance") -> bool: | ||||||
if isinstance(other, Distance): | ||||||
return self.km > other.km | ||||||
elif isinstance(other, (int, float)): | ||||||
return self.km > other | ||||||
|
||||||
def __eq__(self, other: "Distance") -> bool: | ||||||
if isinstance(other, Distance): | ||||||
return self.km == other.km | ||||||
elif isinstance(other, (int, float)): | ||||||
return self.km == other | ||||||
|
||||||
def __le__(self, other: "Distance") -> bool: | ||||||
if isinstance(other, Distance): | ||||||
return self.km <= other.km | ||||||
elif isinstance(other, (int, float)): | ||||||
return self.km <= other | ||||||
|
||||||
def __ge__(self, other: "Distance") -> bool: | ||||||
if isinstance(other, Distance): | ||||||
return self.km >= other.km | ||||||
elif isinstance(other, (int, float)): | ||||||
return self.km >= other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other
can be of type int or float as well. fix anything that needs correctionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not fixed