Solution #801
Closed
Solution #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktoria-rybenchuk
suggested changes
Oct 17, 2023
app/main.py
Outdated
Comment on lines
36
to
39
| result = self.km / divisor | ||
| return Distance(round(result, 2)) | ||
| else: | ||
| raise TypeError("Unsupported operand type") |
app/main.py
Outdated
Comment on lines
36
to
37
| result = self.km / divisor | ||
| return Distance(round(result, 2)) |
app/main.py
Outdated
Comment on lines
42
to
43
| return self.km < other.km if isinstance(other, Distance)\ | ||
| else self.km < other |
There was a problem hiding this comment.
You can improve the readability of the code by using parentheses to break the line instead of a backslash. Fix in all places
There was a problem hiding this comment.
not fixe. Fix in all places
app/main.py
Outdated
| return Distance(self.km + other.km) | ||
| elif isinstance(other, (int, float)): | ||
| return Distance(self.km + other) | ||
| else: |
pavlejviki
suggested changes
Oct 21, 2023
viktoria-rybenchuk
suggested changes
Oct 21, 2023
app/main.py
Outdated
Comment on lines
42
to
43
| return self.km < other.km if isinstance(other, Distance)\ | ||
| else self.km < other |
There was a problem hiding this comment.
not fixe. Fix in all places
app/main.py
Outdated
| def __repr__(self) -> str: | ||
| return f"Distance(km={self.km})" | ||
|
|
||
| def __add__(self, other: int | float) -> int | float | object: |
There was a problem hiding this comment.
other can be Distance as well, fix in all places
There was a problem hiding this comment.
Are you sure about return annotations?
viktoria-rybenchuk
suggested changes
Oct 24, 2023
Co-authored-by: Viktoriia Rybenchuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.