Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #801

Closed
wants to merge 5 commits into from
Closed
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 58 additions & 2 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,59 @@
class Distance:
# Write your code here
pass
def __init__(self, km: float | int) -> None:
self.km = km

def __str__(self) -> str:
return f"Distance: {self.km} kilometers."

def __repr__(self) -> str:
return f"Distance(km={self.km})"

def __add__(self, other: int | float) -> int | float | object:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other can be Distance as well, fix in all places

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about return annotations?

if isinstance(other, Distance):
return Distance(self.km + other.km)
elif isinstance(other, (int, float)):
return Distance(self.km + other)
else:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need else here?

raise TypeError("Unsupported operand type")

def __iadd__(self, other: int | float) -> int | float | object:
Artem-user-19 marked this conversation as resolved.
Show resolved Hide resolved
if isinstance(other, Distance):
self.km += other.km
elif isinstance(other, (int, float)):
self.km += other
else:
raise TypeError("Unsupported operand type")
return self

def __mul__(self, scalar: int | float) -> int | float | object:
if isinstance(scalar, (int, float)):
return Distance(self.km * scalar)
else:
raise TypeError("Unsupported operand type")

def __truediv__(self, divisor: int | float) -> int | float | object:
if isinstance(divisor, (int, float)):
result = self.km / divisor
return Distance(round(result, 2))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't create variable

else:
raise TypeError("Unsupported operand type")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need else?


def __lt__(self, other: int | float) -> int | float | object | bool:
return self.km < other.km if isinstance(other, Distance)\
else self.km < other

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can improve the readability of the code by using parentheses to break the line instead of a backslash. Fix in all places

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not fixe. Fix in all places

Artem-user-19 marked this conversation as resolved.
Show resolved Hide resolved

def __gt__(self, other: int | float) -> int | float | object | bool:
return self.km > other.km if isinstance(other, Distance) else\
self.km > other

def __eq__(self, other: int | float) -> int | float | object | bool:
return self.km == other.km if isinstance(other, Distance) else\
self.km == other

def __le__(self, other: int | float) -> bool:
return self.km <= other.km if isinstance(other, Distance) else\
self.km <= other

def __ge__(self, other: int | float) -> bool:
return self.km >= other.km if isinstance(other, Distance) else\
self.km >= other