-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #801
Solution #801
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,59 @@ | ||
class Distance: | ||
# Write your code here | ||
pass | ||
def __init__(self, km: float | int) -> None: | ||
self.km = km | ||
|
||
def __str__(self) -> str: | ||
return f"Distance: {self.km} kilometers." | ||
|
||
def __repr__(self) -> str: | ||
return f"Distance(km={self.km})" | ||
|
||
def __add__(self, other: int | float) -> int | float | object: | ||
if isinstance(other, Distance): | ||
return Distance(self.km + other.km) | ||
elif isinstance(other, (int, float)): | ||
return Distance(self.km + other) | ||
else: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do you need |
||
raise TypeError("Unsupported operand type") | ||
|
||
def __iadd__(self, other: int | float) -> int | float | object: | ||
Artem-user-19 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
if isinstance(other, Distance): | ||
self.km += other.km | ||
elif isinstance(other, (int, float)): | ||
self.km += other | ||
else: | ||
raise TypeError("Unsupported operand type") | ||
return self | ||
|
||
def __mul__(self, scalar: int | float) -> int | float | object: | ||
if isinstance(scalar, (int, float)): | ||
return Distance(self.km * scalar) | ||
else: | ||
raise TypeError("Unsupported operand type") | ||
|
||
def __truediv__(self, divisor: int | float) -> int | float | object: | ||
if isinstance(divisor, (int, float)): | ||
result = self.km / divisor | ||
return Distance(round(result, 2)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. don't create variable |
||
else: | ||
raise TypeError("Unsupported operand type") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why do you need |
||
|
||
def __lt__(self, other: int | float) -> int | float | object | bool: | ||
return self.km < other.km if isinstance(other, Distance)\ | ||
else self.km < other | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can improve the readability of the code by using parentheses to break the line instead of a backslash. Fix in all places There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not fixe. Fix in all places
Artem-user-19 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
def __gt__(self, other: int | float) -> int | float | object | bool: | ||
return self.km > other.km if isinstance(other, Distance) else\ | ||
self.km > other | ||
|
||
def __eq__(self, other: int | float) -> int | float | object | bool: | ||
return self.km == other.km if isinstance(other, Distance) else\ | ||
self.km == other | ||
|
||
def __le__(self, other: int | float) -> bool: | ||
return self.km <= other.km if isinstance(other, Distance) else\ | ||
self.km <= other | ||
|
||
def __ge__(self, other: int | float) -> bool: | ||
return self.km >= other.km if isinstance(other, Distance) else\ | ||
self.km >= other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other can be
Distance
as well, fix in all placesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure about return annotations?