Solution #822
Open
Solution #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktoria-rybenchuk
suggested changes
Oct 28, 2023
app/main.py
Outdated
Comment on lines
22
to
27
| self.km += other.km | ||
| return self | ||
| elif isinstance(other, (int, float)): | ||
| self.km += other | ||
| return self | ||
|
|
There was a problem hiding this comment.
Prefer using a single return statement for clarity
app/main.py
Outdated
Comment on lines
54
to
59
| def __le__(self, other: Distance | int | float) -> bool: | ||
| if isinstance(other, Distance): | ||
| return self.km <= other.km | ||
| elif isinstance(other, (int, float)): | ||
| return self.km <= other | ||
|
|
There was a problem hiding this comment.
To simplify the code for the method, you can use the concise approach by making use of the not self > other expression. The same you can make in __ge__ method
vsmutok
suggested changes
Oct 28, 2023
app/main.py
Outdated
Comment on lines
35
to
40
| def __lt__(self, other: Distance | int | float) -> bool: | ||
| if isinstance(other, Distance): | ||
| return self.km < other.km | ||
| elif isinstance(other, (int, float)): | ||
| return self.km < other | ||
|
|
There was a problem hiding this comment.
Suggested change
| def __lt__(self, other: Distance | int | float) -> bool: | |
| if isinstance(other, Distance): | |
| return self.km < other.km | |
| elif isinstance(other, (int, float)): | |
| return self.km < other | |
| def __lt__(self, other: Distance | int | float) -> bool: | |
| if isinstance(other, Distance): | |
| return self.km < other.km | |
| elif isinstance(other, (int, float)): | |
| return self.km < other | |
| else: | |
| raise TypeError("some message") | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.