Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #822

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 63 additions & 2 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,64 @@
from __future__ import annotations


class Distance:
# Write your code here
pass
def __init__(self, km: int | float) -> None:
self.km = km

def __repr__(self) -> str:
return f"Distance(km={self.km})"

def __str__(self) -> str:
return f"Distance: {self.km} kilometers."

def __add__(self, other: Distance | int | float) -> Distance:
if isinstance(other, Distance):
return Distance(self.km + other.km)
elif isinstance(other, (int, float)):
return Distance(self.km + other)

def __iadd__(self, other: Distance | int | float) -> Distance:
if isinstance(other, Distance):
self.km += other.km
return self
elif isinstance(other, (int, float)):
self.km += other
return self

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer using a single return statement for clarity

def __mul__(self, other: int | float) -> Distance:
if isinstance(other, (int, float)):
return Distance(self.km * other)

def __truediv__(self, other: int | float) -> Distance:
if isinstance(other, (int, float)):
return Distance(round(self.km / other, 2))

def __lt__(self, other: Distance | int | float) -> bool:
if isinstance(other, Distance):
return self.km < other.km
elif isinstance(other, (int, float)):
return self.km < other

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def __lt__(self, other: Distance | int | float) -> bool:
if isinstance(other, Distance):
return self.km < other.km
elif isinstance(other, (int, float)):
return self.km < other
def __lt__(self, other: Distance | int | float) -> bool:
if isinstance(other, Distance):
return self.km < other.km
elif isinstance(other, (int, float)):
return self.km < other
else:
raise TypeError("some message")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix everywhere

def __gt__(self, other: Distance | int | float) -> bool:
if isinstance(other, Distance):
return self.km > other.km
elif isinstance(other, (int, float)):
return self.km > other

def __eq__(self, other: Distance | int | float) -> bool:
if isinstance(other, Distance):
return self.km == other.km
elif isinstance(other, (int, float)):
return self.km == other

def __le__(self, other: Distance | int | float) -> bool:
if isinstance(other, Distance):
return self.km <= other.km
elif isinstance(other, (int, float)):
return self.km <= other

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To simplify the code for the method, you can use the concise approach by making use of the not self > other expression. The same you can make in __ge__ method

def __ge__(self, other: Distance | int | float) -> bool:
if isinstance(other, Distance):
return self.km >= other.km
elif isinstance(other, (int, float)):
return self.km >= other
Loading