feat: Implement a wait after startup_beep_done to sync multiple ESCs #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we allow each ESCs on a craft to have their own startup tune, each of them may finish playing at a different time. Hence we implpement a 16 bit configurable wait after playing startup tune. This should allow us to wait up to 65536 ms. The Eeprom variables to configure these wait times are: Eep_Pgm_Tune_Wait_MSB_ms - most significant byte Eep_Pgm_Tune_Wait_LSB_ms - least significant byte Total wait = Eep_Pgm_Tune_Wait_MSB_ms*255 + Eep_Pgm_Tune_Wait_LSB_ms TODO: Make sure these values are set to 0 by default
|
Any reason why this isn't ready to be merged? Wouldn't this help fix #19 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we allow each ESCs on a craft to have their own startup tune, each of
them may finish playing at a different time.
Hence we implpement a 16 bit configurable wait after playing startup
tune. This should allow us to wait up to 65536 ms.
The Eeprom variables to configure these wait times are:
Eep_Pgm_Tune_Wait_MSB_ms - most significant byte
Eep_Pgm_Tune_Wait_LSB_ms - least significant byte
Total wait = Eep_Pgm_Tune_Wait_MSB_ms*255 + Eep_Pgm_Tune_Wait_LSB_ms
TODO: Make sure these values are set to 0 by default