Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rtcm example #748

Merged
merged 3 commits into from
Feb 1, 2025
Merged

Fix rtcm example #748

merged 3 commits into from
Feb 1, 2025

Conversation

Pjort
Copy link
Contributor

@Pjort Pjort commented Jan 30, 2025

This fixes the example to use base64 encoded string RTCM data, which is expected by MAVSDK 3.0.0

Also removes old RTK example script from MAVSDK 1.x

@Pjort
Copy link
Contributor Author

Pjort commented Jan 30, 2025

Was tested on real hardware running newest version of PX4, and using real rtcm data. Managed to get RKT Fix. But without this fix I got no errors, but also no RTK fix nor float.

JonasVautherin
JonasVautherin previously approved these changes Jan 30, 2025
Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks! Small nitpick below.

examples/rtcm.py Show resolved Hide resolved
examples/rtcm.py Outdated Show resolved Hide resolved
Yes, of course 😆

Co-authored-by: Julian Oes <[email protected]>
@julianoes julianoes merged commit fdd820b into mavlink:main Feb 1, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants