fix flaky UT #176
fix flaky UT #176
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mshitrit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mshitrit
force-pushed
the
fix-flaky-ut
branch
from
2528ffd to
24340e7
Compare
|
/test 4.14-openshift-e2e |
controllers/tests/controller/selfnoderemediation_controller_test.go
Outdated
Show resolved
Hide resolved
|
Can you separate fixing flaky UT, and removing VA logic into two commits? It would be easier for future us to know if flaky UT is related to VA logic. Do you happen to understand why this unit test is flaky? |
Signed-off-by: Michael Shitrit <[email protected]>
Signed-off-by: Michael Shitrit <[email protected]>
mshitrit
force-pushed
the
fix-flaky-ut
branch
from
24340e7 to
d46a054
Compare
Sure done.
Not sure if you refer to a specific failure regarding the VA or in general. |
|
/test 4.14-openshift-e2e |
|
/lgtm |
| } | ||
|
|
||
| func verifyNoEvent(eventType, reason, message string) { | ||
| isEventMatch := isEventOccurred(eventType, reason, message) | ||
| ExpectWithOffset(1, isEventMatch).To(BeFalse()) | ||
| EventuallyWithOffset(1, func() bool { |
There was a problem hiding this comment.
this should be Consistently I guess?
Fixing flaky UT, and removing VA logic since SNR does not delete VA's anymore