Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix semantic camera #799

Merged
merged 1 commit into from
Jan 18, 2025
Merged

fix semantic camera #799

merged 1 commit into from
Jan 18, 2025

Conversation

DhlinV
Copy link
Collaborator

@DhlinV DhlinV commented Jan 17, 2025 •
edited
Loading

What changes do you make in this PR?

  • Please describe why you create this PR
  1. Remove multisamples in semantic camera to disable anti-aliasing, which is harmful for semantic rendering
  2. Change the order of functions in simgen

Checklist

  • I have merged the latest main branch into current branch.
  • I have run bash scripts/format.sh before merging.
  • Please use "squash and merge" mode.

@DhlinV DhlinV requested a review from pengzhenghao January 17, 2025 19:48
@QuanyiLi QuanyiLi merged commit 12b2bdc into main Jan 18, 2025
13 of 14 checks passed
@QuanyiLi QuanyiLi deleted the fix-semantic branch January 18, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pengzhenghao pengzhenghao Awaiting requested review from pengzhenghao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DhlinV @QuanyiLi