Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arcbox 3.0 task 919 optimizations #2337

Merged
merged 12 commits into from
Dec 29, 2023
Merged

Arcbox 3.0 task 919 optimizations #2337

merged 12 commits into from
Dec 29, 2023

Conversation

janegilring
Copy link
Contributor

@janegilring janegilring commented Dec 29, 2023 •
edited
Loading

  • Leveraged Foreach-Object -Parallel where applicable
  • Replaced 7z with Compress-Archive
  • Replaced System.IO.File]::Exists with Test-Path
  • SQL server BPA code optimization to avoid Cannot index into a null array in deployment logs

@janegilring
Leveraged Foreach-Object -Parallel where applicable
1984065 
Signed-off-by: Jan Egil Ring <[email protected]>
@janegilring
Enabled Azure CLI use_dynamic_install for extensions
cb788ce 
Signed-off-by: Jan Egil Ring <[email protected]>
@janegilring
Added Connect-AzAccount inside ForEach-Object -Parallel
f82fd1e 
Signed-off-by: Jan Egil Ring <[email protected]>
@janegilring
Replace 7z with Compress-Archive. Leverage env-variable for temp-folder.
c68fd37 
Signed-off-by: Jan Egil Ring <[email protected]>
@janegilring
Moved Creating deployment logs bundle at the end
25b8553 
Signed-off-by: Jan Egil Ring <[email protected]>
@janegilring
Replace System.IO.File]::Exists with Test-Path
c6c8688 
Signed-off-by: Jan Egil Ring <[email protected]>
@janegilring
Replace System.IO.File Exists with Test-Path
c9066cb 
Signed-off-by: Jan Egil Ring <[email protected]>
@janegilring
Bugfix - syntax
c43bdab 
Signed-off-by: Jan Egil Ring <[email protected]>
@janegilring
Bugfix - temp dir reference
6087197 
Signed-off-by: Jan Egil Ring <[email protected]>
@janegilring
Added workaround to avoid "file is being used by another process" err…
bcbfbcb 
…or when compressing the logs

Signed-off-by: Jan Egil Ring <[email protected]>
@janegilring
SQL server BPA optimization to avoid Cannot index into a null array i…
a38fa49 
…n deployment logs. Suppress irrelevant warning.

Signed-off-by: Jan Egil Ring <[email protected]>
@janegilring
Added Az PowerShell Login
2fdbe35 
Signed-off-by: Jan Egil Ring <[email protected]>
@janegilring janegilring merged commit b1b3c21 into microsoft:arcbox_3.0 Dec 29, 2023
2 checks passed
github-actions[bot]
github-actions bot reviewed Dec 29, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi friend! Thanks you for opening this Pull Request. Someone will review it soon. Thank you for committing to making the Azure Arc Jumpstart better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@janegilring