Path gets blacked on hover in terminal if hoverHighlightBackground is opaque

[AnilSonix]

• VSCode Version: 1.46.0-Insider
• OS Version: Ubuntu 20.04

Steps to Reproduce:

1. Open any folder or workspace
2. Open terminal
3. Navigate to any nested directories.
4. Hover over the path in the terminal.
5. The path becomes black.

Does this issue occur when all extensions are disabled?: No

[Tyriar]

I'm guessing you have a non-transparent color set as editor.hoverHighlightBackground in your theme.

[AnilSonix]

How can I override it ?

[Tyriar]

This setting:

"workbench.colorCustomizations": {
  "editor.hoverHighlightBackground": "#ff000080"
}

[AnilSonix]

Thank you 👍

[dsifford]

Following the instructions you provided @AnilSonix I still cannot reproduce this.

[Tyriar]

The proper fix for this to draw the highlight under the text probably needs xtermjs/xterm.js#1852 to happen. We could do a workaround to make the color partially transparent if it's detected as opaque.

[dsifford]

Cool, thanks for the update @Tyriar

Just went ahead and merged @AnilSonix's workaround in dracula theme for the time being. I was finally able to repro on my end 👍

[ChrisPapp]

Can I work on this?

[Tyriar]

@ChrisPapp I'll have to do a quick fix on this to squeeze it in for this release.

[ChrisPapp]

@Tyriar I have made a quick fix myself. I can push it now and you can take a look.

[Tyriar]

@ChrisPapp if it's ready now, sure! 👍