2116: improve resilience of posthog integration #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rhysyngsun I don't understand why is reporting that I need to make change logs for a bunch of apps that I didn't modify. That doesn't seem right. |
jkachel
approved these changes
Apr 24, 2024
src/mitol/olposthog/README.md
Outdated
| #### Retrieve all feature flags from Posthog | ||
| You can retrieve all the feature flags from Posthog using: | ||
| ``` | ||
| from mitol.olposthog.features import is_enabled |
There was a problem hiding this comment.
Small thing - import needs to be updated
| @@ -0,0 +1,34 @@ | |||
| .. A new scriv changelog fragment. | |||
There was a problem hiding this comment.
Small thing - should this have a log entry?
collinpreston
deleted the
2116-improve-resilience-of-posthog-integration-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
mitodl/mitxonline#2116
Description
Defines the generic Posthog functionality found in MITx Online and MIT Open to ol-django. This ol-django functionality will later be imported into MIT Open and MITx Online in order to reduce redundant code across our applications.
How can this be tested?
You can use this MITx Online branch to test the functionality provided by this PR: https://github.com/mitodl/mitxonline/tree/ol-django-posthog
Test setup
You will need to perform the following steps in order to test this PR using the MITx Online branch above.
pants package "src/mitol/olposthog:"docker-compose run -u root --rm web poetry add ./mitol-django-olposthog-2024.4.16.tar.gz.docker-compose run -u root --rm web poetry install.docker-compose build.docker-compose up.POSTHOG_ENABLED=Trueis defined in your .env file.POSTHOG_ENABLED=Falseis defined in your .env file.