fix(ignite): making state saveable, param_groups modifieable #1235
+104
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(ignite): making state saveable, param_groups modifieable It was impossible to save the state because of: * mlverse#1233 * undefined tensors were part of the state such as max_exp_avg_sq for adam with amsgrad = FALSE. We now keep them as 0-sized tensors as undefined tensors are not serializeable. (The reason we keep them at all is that it simplifies the saving and loading of state dicts easier) This PR also improves the tests by removing an unnecessary call to `torch_manual_seed()` that made the tests deterministic
|
@dfalbel Can you tag this with 'lantern' again please? I forgot to test the saving of the state dict which was not possible. |
dfalbel
added
the
lantern
|
Done! @sebffischer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was impossible to save the state because of:
This PR also improves the tests by removing an unnecessary call to
torch_manual_seed()that made the tests deterministic