Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI/CD analyzer crashes #1033

Merged
merged 11 commits into from
Dec 16, 2024
Merged

Fix CI/CD analyzer crashes #1033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3aff2cc
remove explicit WidgetBuilder type
Dec 16, 2024
ea55483
Merge branch 'main' into fix_analyze_errors
subzero911 Dec 16, 2024
5431c0b
ignore
Dec 16, 2024
974b7fc
Merge remote-tracking branch 'origin/fix_analyze_errors' into fix_ana…
Dec 16, 2024
95d1d43
Revert "ignore"
Dec 16, 2024
6887d51
Revert "remove explicit WidgetBuilder type"
Dec 16, 2024
485614c
upd. flutter_lints
Dec 16, 2024
78a9a25
remove lib name
Dec 16, 2024
f262692
Revert "remove lib name"
Dec 16, 2024
cd77e14
ignore warning
Dec 16, 2024
400e590
fix unused_element
Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions flutter_mobx/lib/flutter_mobx.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
/// );
///

// ignore: unnecessary_library_name
library flutter_mobx;

export 'package:flutter_mobx/src/multi_reaction_builder.dart';
Expand Down
4 changes: 2 additions & 2 deletions flutter_mobx/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ homepage: https://mobx.netlify.app
topics:
- reactive-programming
- state-management
- ui
- user-interface

environment:
sdk: ">=3.0.0 <4.0.0"
Expand All @@ -24,7 +24,7 @@ dependencies:

dev_dependencies:
build_runner: ^2.4.9
flutter_lints: ^4.0.0
flutter_lints: ^5.0.0
flutter_test:
sdk: flutter
mocktail: ^1.0.3
2 changes: 2 additions & 0 deletions mobx_codegen/analysis_options.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
include: package:lints/recommended.yaml

analyzer:
errors:
unused_element: ignore
exclude:
- test/data/**.dart
- test/*.g.dart
1 change: 0 additions & 1 deletion mobx_codegen/test/generator_usage_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ class TestStore = _TestStore with _$TestStore;
bool customEquals(String? oldValue, String? newValue) => oldValue != newValue;

abstract class _TestStore with Store {
// ignore: unused_element
_TestStore(this.field1, {this.field2});

@observable
Expand Down
2 changes: 1 addition & 1 deletion mobx_examples/lib/todos/todo_widgets.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ class ActionBar extends StatelessWidget {
},
),
Observer(
builder: (_) => ButtonBar(
builder: (_) => OverflowBar(
children: <Widget>[
ElevatedButton(
onPressed: list.canRemoveAllCompleted
Expand Down
Loading