Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI/CD analyzer crashes #1033

Merged
merged 11 commits into from
Dec 16, 2024
Merged

Conversation

subzero911
Copy link
Contributor

Fixes #1029 (comment)

remove explicit WidgetBuilder type


Pull Request Checklist

  • If the changes are being made to code, ensure the version in pubspec.yaml is updated.
  • Increment the major/minor/patch/patch-count, depending on the complexity of change
  • Add the necessary unit tests to ensure the coverage does not drop
  • Update the Changelog to include all changes made in this PR, organized by version
  • Run the melos run set_version command from the root directory
  • Include the necessary reviewers for the PR
  • Update the docs if there are any API changes or additions to functionality

@subzero911
Copy link
Contributor Author

subzero911 commented Dec 16, 2024

@pavanpodila I made a new PR to check this.
image

This error disappeared.
But still got this error:
image

@subzero911
Copy link
Contributor Author

image

Something wrong with your CI/CD.
It treats warnings like fatal errors.

@subzero911
Copy link
Contributor Author

image image

by the way, docs are not working without library directive

@pavanpodila
Copy link
Member

minor analysis issues to fix and we are good to merge

@pavanpodila pavanpodila merged commit 7dec21a into mobxjs:main Dec 16, 2024
3 of 7 checks passed
@subzero911
Copy link
Contributor Author

hey, what you doing?!
I'm still testing!

@subzero911
Copy link
Contributor Author

@pavanpodila revert it back

This was referenced Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants