Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests now that Ubuntu 24.04 is the new default #313

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

jajik
Copy link
Collaborator

@jajik jajik commented Jan 9, 2025

No description provided.

@jajik
Copy link
Collaborator Author

jajik commented Jan 9, 2025

Switching from moby-* to podman-docker....

@jajik jajik requested a review from rhusar January 9, 2025 16:12
@rhusar
Copy link
Member

rhusar commented Jan 9, 2025

Switching from moby-* to podman-docker....

Much better. If this works well I ll merge this variant.

@rhusar rhusar added this to the 2.0.0.Beta1 milestone Jan 9, 2025
@rhusar rhusar self-assigned this Jan 9, 2025
`docker` was removed in the new image, moby-* packages can be used instead as well

/etc/containers/nodocker is required for `Emulate Docker CLI using podman` msg to disappear
@jajik jajik force-pushed the use-ubuntu-latest branch from 9afad00 to aebd52d Compare January 9, 2025 17:30
@jajik
Copy link
Collaborator Author

jajik commented Jan 9, 2025

Added sudo touch /etc/containers/nodocker to make the message about podman-docker emulation go away...

Copy link
Member

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

@rhusar rhusar merged commit ffc8aac into modcluster:main Jan 9, 2025
10 checks passed
@rhusar
Copy link
Member

rhusar commented Jan 9, 2025

Thanks @jajik

@jajik jajik deleted the use-ubuntu-latest branch January 9, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants