Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(catalogue): extend Resources table to accomodate description of samples collected next to the data #4681
base: master
Are you sure you want to change the base?
feat(catalogue): extend Resources table to accomodate description of samples collected next to the data #4681
Changes from 7 commits
f9c7052
311b6b5
bb7b192
3b90939
fa788ee
c0f2e00
eea9325
8752b32
075f301
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is biospecimen types niet hetzelfde als material types? Of hebben we die alleen op collection event? In any case graag gelijk houden.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dit is de huidige stand van zaken in de catalogus:
Collection event.sample categories -> CatalogueOntologies.Sample categories (310 entries)
Samplesets.sample types -> CatalogueOntologies.Sample types (5 entries)
Resources.biospecimen collected -> CatalogueOntologies.Biospecimens (0 entries)
in RD3/FAIR Genome/DCAT:
Biosamples.BioSpecimenType -> CatalogueOntologies.BiospecimenType (416 entries)
in Directory:
Collection.materials -> DirectoryOntologies.MaterialTypes (22 entries)
Dan lijkt het me een kwestie van kiezen tussen Sample categories en BiospecimenType . Die twee lijken niet heel compatibel; Sample categories is gebaseerd op MeSH, BiospecimenType op NCIT.