Emitting event when setting external validators #857
+185
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksandar Brayanov <[email protected]>
chexware
added
D3-trivial
tmpolaczyk
reviewed
Feb 7, 2025
WASM runtime size check:Compared to target branchdancebox runtime: 1416 KB (no changes) ✅ flashbox runtime: 824 KB (no changes) ✅ dancelight runtime: 2168 KB (no changes) ✅ container chain template simple runtime: 1116 KB (no changes) ✅ container chain template frontier runtime: 1404 KB (no changes) ✅ |
Signed-off-by: Aleksandar Brayanov <[email protected]>
Signed-off-by: Aleksandar Brayanov <[email protected]>
Signed-off-by: Aleksandar Brayanov <[email protected]>
Coverage Report@@ Coverage Diff @@
## master aleks-emit-event-on-external-validator-registration +/- ##
=======================================================================================
+ Coverage 65.97% 66.05% +0.08%
- Files 339 335 -4
- Lines 59084 58856 -228
=======================================================================================
- Hits 38978 38872 -106
- Misses 20106 19984 -122
|
girazoki
reviewed
Feb 10, 2025
…pected event Signed-off-by: Aleksandar Brayanov <[email protected]>
…pected event when more than max validators are passed as input Signed-off-by: Aleksandar Brayanov <[email protected]>
…istration # Conflicts: # typescript-api/src/dancelight/interfaces/augment-api-events.ts # typescript-api/src/dancelight/interfaces/lookup.ts
Signed-off-by: Aleksandar Brayanov <[email protected]>
…dators through middleware contract for test_zombie_tanssi_relay_eth_bridge.ts Signed-off-by: Aleksandar Brayanov <[email protected]>
…ssi_relay_eth_bridge.ts Signed-off-by: Aleksandar Brayanov <[email protected]>
girazoki
approved these changes
Feb 14, 2025
tmpolaczyk
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting external validators now emits an event