Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emitting event when setting external validators #857

Merged
merged 13 commits into from
Feb 19, 2025
Merged

Emitting event when setting external validators #857

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4aefe74
feat: emitting event in set_external_validator_inner
chexware Feb 7, 2025
13a848e
refactor: reference external validators list instead of cloning it
chexware Feb 7, 2025
92dbe87
Merge branch 'master' into aleks-emit-event-on-external-validator-reg…
chexware Feb 7, 2025
9e681c8
chore: updated typescript APIs
chexware Feb 7, 2025
08ad95a
chore: added missing api-augment types
chexware Feb 7, 2025
a18edab
test: added test verifying that set_external_validator_inner emits ex…
chexware Feb 10, 2025
e82b9e7
test: added test verifying that set_external_validator_inner emits ex…
chexware Feb 10, 2025
7ebd87d
Merge branch 'master' into aleks-emit-event-on-external-validator-reg…
chexware Feb 12, 2025
759cc6e
chore: updated typescript interfaces after merging with master
chexware Feb 12, 2025
c0c0435
test: added check whether event is emitted when setting external vali…
chexware Feb 12, 2025
c044d83
revert: removed ExternalValidatorSet event check from test_zombie_tan…
chexware Feb 12, 2025
30067e7
Merge branch 'master' into aleks-emit-event-on-external-validator-reg…
chexware Feb 19, 2025
a0767c3
Merge branch 'master' into aleks-emit-event-on-external-validator-reg…
chexware Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pallets/external-validators/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,8 @@ pub mod pallet {
NewEra { era: EraIndex },
/// A new force era mode was set.
ForceEra { mode: Forcing },
/// External validators were set.
ExternalValidatorsSet { validators: Vec<T::ValidatorId>, external_index: u64 },
}

#[pallet::error]
Expand Down Expand Up @@ -380,8 +382,10 @@ pub mod pallet {
) -> DispatchResult {
// If more validators than max, take the first n
let validators = BoundedVec::truncate_from(validators);
<ExternalValidators<T>>::put(validators);
<ExternalValidators<T>>::put(validators.clone());
<ExternalIndex<T>>::put(external_index);

Self::deposit_event(Event::<T>::ExternalValidatorsSet { validators: validators.into_inner(), external_index });
Ok(())
}

Expand Down
Loading