Fixes MTE-3890 - for flaky smoke tests (backport #23389) (#23395)

Fixes MTE-3890 - for flaky smoke tests (#23389) (cherry picked from commit ad0a142) Co-authored-by: dragosb01 <[email protected]>
mozilla-mobile · Nov 26, 2024 · 4644e1d · 4644e1d
1 parent 25ff72d
commit 4644e1d
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/firefox-ios/firefox-ios-tests/Tests/XCUITests/AddressesTests.swift b/firefox-ios/firefox-ios-tests/Tests/XCUITests/AddressesTests.swift
@@ -191,10 +191,9 @@ class AddressesTests: BaseTestCase {
         updateAddress(updateCountry: updateCountry, isPostalCode: isPostalCode)
         tapSave()
         // The "Address saved" toast message is displayed
-        // mozWaitForElementToExist(app.staticTexts[addressSavedTxt])
+        mozWaitForElementToExist(app.staticTexts[addressSavedTxt])
         // The address is saved
-        // Update with correct toast message after https://mozilla-hub.atlassian.net/browse/FXIOS-10422 is fixed
-        // mozWaitForElementToExist(app.staticTexts[savedAddressesTxt])
+        mozWaitForElementToExist(app.staticTexts[savedAddressesTxt])
         if updateCountry {
             let addressInfo = ["Test2", "test address2", "city test2, 100000"]
             for index in addressInfo {
@@ -318,8 +317,12 @@ class AddressesTests: BaseTestCase {
         app.typeText(email)
     }
 
-    private func tapSave() {
-        app.buttons["Save"].tapWithRetry()
+    private func tapSave(withRetry: Bool = false) {
+        if withRetry {
+            app.buttons["Save"].tapWithRetry()
+        } else {
+            app.buttons["Save"].tap()
+        }
     }
 
     private func tapEdit() {

diff --git a/firefox-ios/firefox-ios-tests/Tests/XCUITests/BookmarksTests.swift b/firefox-ios/firefox-ios-tests/Tests/XCUITests/BookmarksTests.swift
@@ -148,6 +148,7 @@ class BookmarksTests: BaseTestCase {
         navigator.nowAt(BrowserTab)
 
         // Clear text and enter new url
+        waitUntilPageLoad()
         waitForTabsButton()
         navigator.performAction(Action.OpenNewTabFromTabTray)
         navigator.goto(URLBarOpen)

diff --git a/firefox-ios/firefox-ios-tests/Tests/XCUITests/DragAndDropTests.swift b/firefox-ios/firefox-ios-tests/Tests/XCUITests/DragAndDropTests.swift
@@ -192,6 +192,7 @@ private extension BaseTestCase {
             navigator.nowAt(NewTabScreen)
         }
         navigator.openURL(firstWebsite.url)
+        waitUntilPageLoad()
         waitForTabsButton()
         navigator.performAction(Action.OpenNewTabFromTabTray)
         navigator.nowAt(NewTabScreen)