Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor [v124] fix warnings + lower threshold #18613

Merged
merged 6 commits into from
Feb 7, 2024

Conversation

lmarceau
Copy link
Contributor

@lmarceau lmarceau commented Feb 7, 2024

📜 Tickets

No ticket

💡 Description

Fix warnings + lower warnings threshold

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed I updated documentation / comments for complex code and public methods

@lmarceau lmarceau requested review from a team as code owners February 7, 2024 14:43
Copy link
Contributor

@cyndichin cyndichin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 thank you!

@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 33.13%
📖 Edited 5 files
📖 Created 0 files

Client.app: Coverage: 31.86

File Coverage
MetadataParserHelper.swift 6.12% ⚠️

Generated by 🚫 Danger Swift against df977ea

@lmarceau lmarceau merged commit 5afe277 into mozilla-mobile:main Feb 7, 2024
10 checks passed
@lmarceau lmarceau deleted the lm/fix-warning branch February 7, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants