Add MTE-2449 TestRail links for TrackingProtection tests #19345
Conversation
|
@clarmso please see my comments in the doc. It is not only about adding the links in here but having a proper matching between the tests. We should have Autoamted and test rail manual tests parity and structured as much similar as possible |
| @@ -4,7 +4,8 @@ | |||
|
|
|||
| import XCTest | |||
|
|
|||
| class TrackingProtectionSettings: BaseTestCase { | |||
| class TrackingProtection: BaseTestCase { | |||
There was a problem hiding this comment.
Should I rename this file?
| @@ -35,18 +36,8 @@ class BasicBrowsing: BaseTestCase { | |||
| XCTAssertTrue(app.buttons["Add"].exists) | |||
| } | |||
|
|
|||
| // Smoke test | |||
| func testAdBlocking() { | |||
There was a problem hiding this comment.
This test is moved to TrackingProtectionTest.
| @@ -49,7 +49,6 @@ | |||
| 45E8FFE72828DE4A0027A8F5 /* FocusAppServices in Frameworks */ = {isa = PBXBuildFile; productRef = 45E8FFE62828DE4A0027A8F5 /* FocusAppServices */; }; | |||
| 4F1284861FC5E242001A775B /* TPSettingsTest.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4F1284851FC5E242001A775B /* TPSettingsTest.swift */; }; | |||
| 4F582F7B1F44A10F006C744B /* OpenInFocusTest.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4F582F7A1F44A10F006C744B /* OpenInFocusTest.swift */; }; | |||
| 4FE4E6F61FBB5E2C001BB779 /* TPSidebarBadge.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4FE4E6F51FBB5E2C001BB779 /* TPSidebarBadge.swift */; }; | |||
There was a problem hiding this comment.
Consolidate both tracking protection tests files into one.
| @@ -15,7 +15,6 @@ | |||
| { | |||
| "skippedTests" : [ | |||
| "AsianLocaleTest", | |||
| "BasicBrowsing\/testLaunchExternalApp()", | |||
There was a problem hiding this comment.
testLaunchExternalApp is supposed to be a smoke test.
| let shareButton: XCUIElement | ||
| if #available(iOS 14, *) { | ||
| shareButton = app.cells.buttons["Share Page With..."] | ||
| shareButton = app.cells.buttons["Share Page With…"] |
There was a problem hiding this comment.
For some reason, the "..." are "…" (just one character) on my end.
| @@ -4,7 +4,8 @@ | |||
|
|
|||
| import XCTest | |||
|
|
|||
| class TrackingProtectionSettings: BaseTestCase { | |||
| class TrackingProtectionTest: BaseTestCase { | |||
There was a problem hiding this comment.
The test suite has the new name but not the Test file, it is still named TPSettingsTest.swift, it would be nice to have the same name
| } | ||
|
|
||
| // https://testrail.stage.mozaws.net/index.php?/cases/view/1569869 | ||
| func testShieldMenuSetting() { |
There was a problem hiding this comment.
I have updated the "Automation" Status of the TestRail test.
https://testrail.stage.mozaws.net/index.php?/cases/view/1569869
|
This pull request has conflicts when rebasing. Could you fix it @clarmso? 🙏 |
📜 Tickets
Jira ticket
💡 Description
Add TestRail tests and attach their links to the corresponding tests.
https://docs.google.com/document/d/1Rj8s9sjNBT_71Cws4arL3M5nwIQaMgci3uyuzzqf5Cg/edit
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)