Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix FXIOS-11128 [ToS] - "Continue" is written with lowercase #24281

Merged
merged 1 commit into from
Jan 22, 2025
+9 −4
Merged

Bugfix FXIOS-11128 [ToS] - "Continue" is written with lowercase #24281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion firefox-ios/Client/Frontend/Onboarding/Views/TermsOfServiceViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ class TermsOfServiceViewController: UIViewController, Themeable {

private lazy var confirmationButton: PrimaryRoundedButton = .build { button in
let viewModel = PrimaryRoundedButtonViewModel(
title: .Onboarding.TermsOfService.AgreementButtonTitle,
title: .Onboarding.TermsOfService.AgreementButtonTitleV2,
a11yIdentifier: AccessibilityIdentifiers.TermsOfService.agreeAndContinueButton)
button.configure(viewModel: viewModel)
button.addTarget(self, action: #selector(self.acceptTermsOfService), for: .touchUpInside)
Expand Down
11 changes: 8 additions & 3 deletions firefox-ios/Shared/Strings.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1664,10 +1664,10 @@ extension String {
tableName: "Onboarding",
value: "Fast and secure web browsing",
comment: "Subtitle for the Terms of Service screen in the onboarding process.")
public static let AgreementButtonTitle = MZLocalizedString(
key: "Onboarding.TermsOfService.AgreementButtonTitle.v135",
public static let AgreementButtonTitleV2 = MZLocalizedString(
key: "Onboarding.TermsOfService.AgreementButtonTitle.v136",
tableName: "Onboarding",
value: "Agree and continue",
value: "Agree and Continue",
comment: "Title for the confirmation button for Terms of Service agreement, in the Terms of Service screen.")
public static let TermsOfServiceAgreement = MZLocalizedString(
key: "Onboarding.TermsOfService.TermsOfServiceAgreement.v135",
Expand Down Expand Up @@ -7694,6 +7694,11 @@ extension String {
tableName: "Settings",
value: "Crash reports allow us diagnose and fix issues with the browser.",
comment: "On the Settings screen, this is the subtitle text for a toggle which controls automatically sending crash reports.")
public static let AgreementButtonTitle = MZLocalizedString(
key: "Onboarding.TermsOfService.AgreementButtonTitle.v135",
tableName: "Onboarding",
value: "Agree and continue",
comment: "Title for the confirmation button for Terms of Service agreement, in the Terms of Service screen.")
}
}
}
Expand Down