Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix FXIOS-11128 [ToS] - "Continue" is written with lowercase #24281

Merged

Conversation

dicarobinho
Copy link
Collaborator

📜 Tickets

Jira ticket

💡 Description

Changed title for Agree and Continue button

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@dicarobinho dicarobinho marked this pull request as ready for review January 22, 2025 13:40
@dicarobinho dicarobinho requested a review from a team as a code owner January 22, 2025 13:40
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 34.11%
📖 Edited 2 files
📖 Created 0 files

Client.app: Coverage: 32.37

File Coverage
TermsOfServiceViewController.swift 83.4%

Generated by 🚫 Danger Swift against 20a2f1a

@dicarobinho dicarobinho merged commit 6a5b26c into main Jan 22, 2025
10 checks passed
@dicarobinho dicarobinho deleted the afarcasanu/fxios_11128_agree_button_continue_lowercased branch January 22, 2025 14:56
clarmso pushed a commit that referenced this pull request Jan 22, 2025
FXIOS-11128 [Terms of service] - "Continue" is written with lowercase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants