vd_lavc: warn about libopenh264 when it's in use #15839
Open
+20
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
llyyr
reviewed
Feb 9, 2025
Fedora users that unwittingly use libopenh264 are a frequent guest on our issue tracker. See e.g. mpv-player#15837 mpv-player#15570 mpv-player#13236 mpv-player#11810 and several occurrences on IRC and probably many more cases we never hear about and the user just concludes that mpv is buggy. In light of this, warn users that their subpar experience is entirely avoidable with an explanation, and leave a little comment block for distro packagers who will probably race to patch out the warning because they don't like it when people make informed decisions.
CounterPillow
force-pushed
the
tips-fedora
branch
from
b8d68be to
af53fae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fedora users that unwittingly use libopenh264 are a frequent guest on our issue tracker. See e.g. #15837 #15570 #13236 #11810 and several occurrences on IRC and probably many more cases we never hear about and the user just concludes that mpv is buggy.
In light of this, warn users that their subpar experience is entirely avoidable with an explanation, and leave a little comment block for distro packagers who will probably race to patch out the warning because they don't like it when people make informed decisions.