Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vd_lavc: warn about libopenh264 when it's in use #15839

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

vd_lavc: warn about libopenh264 when it's in use #15839

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions video/decode/vd_lavc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,6 +715,26 @@ static void init_avctx(struct mp_filter *vd)
if (!lavc_codec)
return;

/*
* DEAR DISTRIBUTION PACKAGER,
* Before removing the check below to silence the users filing bugs against
* your package prompted by it that you can't do anything about, please
* consider the hypocrisy of your actions. libopenh264 users frequently
* report problems on mpv's issue tracker and IRC channel that we can't do
* anything about either.
*/
if (strcmp(ctx->decoder, "libopenh264") == 0) {
MP_WARN(vd, "You are using the libopenh264 decoder, which is known to "
"be very buggy. If you run into issues with mpv while using "
"it, even seemingly unrelated ones like desync or crashes, "
"then please do not report it to mpv's issue tracker.\n"
"There is no reason to use the libopenh264 decoder as a "
"private person, the internal H.264 decoder is also open-"
"source, and libopenh264 only exists to work around alleged "
"patent licensing issues.\n"
);
}

const AVCodecDescriptor *desc = avcodec_descriptor_get(lavc_codec->id);
ctx->intra_only = desc && (desc->props & AV_CODEC_PROP_INTRA_ONLY);

Expand Down