Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composable Nodes #153

Merged
merged 8 commits into from
Jan 8, 2025
Merged

Composable Nodes #153

merged 8 commits into from
Jan 8, 2025

Conversation

dppp415
Copy link
Contributor

@dppp415 dppp415 commented Jan 7, 2025

Nodes pf_localization and pointcloud_pipeline are now composables.

Copy link
Member

@jlblancoc jlblancoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits.

Great job, David @dppp415 ! 🙌

cc'd for visibility: @r-aguilera

mrpt_pf_localization/CMakeLists.txt Show resolved Hide resolved
mrpt_pf_localization/CMakeLists.txt Outdated Show resolved Hide resolved
mrpt_pf_localization/CMakeLists.txt Show resolved Hide resolved
@jlblancoc
Copy link
Member

Just some nits.

Great job, David @dppp415 ! 🙌

cc'd for visibility: @r-aguilera

PS: there was a failing job in CI. Seems spurious and restarted it, let's see...

@jlblancoc jlblancoc enabled auto-merge January 8, 2025 08:21
@jlblancoc
Copy link
Member

Please, rebase from the develop branch or at least copy this changed file so CI can run here:
https://github.com/mrpt-ros-pkg/mrpt_navigation/blob/ros2/.github/workflows/build-ros.yml

auto-merge was automatically disabled January 8, 2025 08:42

Head branch was pushed to by a user without write access

@jlblancoc jlblancoc enabled auto-merge January 8, 2025 09:33
@jlblancoc jlblancoc disabled auto-merge January 8, 2025 10:53
@jlblancoc jlblancoc merged commit 7ef76ca into mrpt-ros-pkg:ros2 Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants