Skip to content

refactor sc-storage #845

refactor sc-storage

refactor sc-storage #845

Triggered via pull request October 29, 2024 12:16
Status Success
Total duration 2m 30s
Artifacts 4

actions.yml

on: pull_request
Contracts  /  Wasm tests
2m 18s
Contracts / Wasm tests
Contracts  /  Test Coverage
47s
Contracts / Test Coverage
Contracts  /  Rust tests
31s
Contracts / Rust tests
Contracts  /  Clippy linter check
24s
Contracts / Clippy linter check
Fit to window
Zoom out
Zoom in

Annotations

8 warnings
[clippy] esdt-safe/tests/esdt_safe_blackbox_test.rs#L462: esdt-safe/tests/esdt_safe_blackbox_test.rs#L462
warning: used `assert_eq!` with a literal bool --> esdt-safe/tests/esdt_safe_blackbox_test.rs:462:5 | 462 | / assert_eq!( 463 | | paused_state_before, false, 464 | | "Contract should not be paused before upgrade" 465 | | ); | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison = note: `#[warn(clippy::bool_assert_comparison)]` on by default help: replace it with `assert!(..)` | 462 ~ assert!( 463 ~ !paused_state_before, |
[clippy] esdt-safe/tests/esdt_safe_blackbox_test.rs#L500: esdt-safe/tests/esdt_safe_blackbox_test.rs#L500
warning: used `assert_eq!` with a literal bool --> esdt-safe/tests/esdt_safe_blackbox_test.rs:500:5 | 500 | / assert_eq!( 501 | | paused_state_after, true, 502 | | "Contract should be paused after upgrade" 503 | | ); | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison help: replace it with `assert!(..)` | 500 ~ assert!( 501 ~ paused_state_after, |
[clippy] esdt-safe/tests/esdt_safe_blackbox_test.rs#L1184: esdt-safe/tests/esdt_safe_blackbox_test.rs#L1184
warning: this let-binding has unit value --> esdt-safe/tests/esdt_safe_blackbox_test.rs:1184:5 | 1184 | / let claim_refund_second = state 1185 | | .esdt_raw_transaction() 1186 | | .claim_refund(MINT_BURN_TOKEN) 1187 | | .returns(ExpectError(ERROR, "Nothing to refund")) 1188 | | .run(); | |_______________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value = note: `#[warn(clippy::let_unit_value)]` on by default help: omit the `let` binding | 1184 ~ state 1185 + .esdt_raw_transaction() 1186 + .claim_refund(MINT_BURN_TOKEN) 1187 + .returns(ExpectError(ERROR, "Nothing to refund")) 1188 + .run(); |
Contracts / Clippy linter check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, giraffate/clippy-action@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Contracts / Rust tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Contracts / Test Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/upload-artifact@v3, peter-evans/find-comment@v2, peter-evans/create-or-update-comment@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Contracts / Wasm tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/upload-artifact@v3, dawidd6/action-download-artifact@v2, peter-evans/find-comment@v2, peter-evans/create-or-update-comment@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "coverage", "mxpy_report", "report", "report-markdown". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Artifacts

Produced during runtime
Name Size
coverage Expired
6.08 KB
mxpy_report Expired
13.9 KB
report Expired
2.16 KB
report-markdown Expired
2.15 KB