Use Conan for External Dependencies #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannes-wolf
force-pushed
the
use-conan
branch
7 times, most recently
from
d9c3ee6 to
2a0d0b3
Compare
|
@josephbirkner Do you know which version of OpenSSL is needed (and why it worked without pulling any before)? |
|
@johannes-wolf OpenSSL 1.1.1 or 3.0 (probably better) is needed. They are currently installed as part of the cmake github action workflow... |
johannes-wolf
force-pushed
the
use-conan
branch
7 times, most recently
from
1e0b379 to
05db7b9
Compare
johannes-wolf
force-pushed
the
use-conan
branch
8 times, most recently
from
c7fa903 to
5f4c9cd
Compare
|
Rebased (+ simfil 0.2.1) |
Disable coverage by default. The CI already enables it explicitly.
johannes-wolf
commented
Jun 20, 2024
Minimum allowed line rate is |
|
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #40.
HUGE CI build performance increase on Windows!
Using conan for dependencies is still optional! The CI uses conan for faster builds.
This PR improves the build times by using Ninja instead of make (with -j1) + sccache
(with filled caches, build takes < 10min).
EDIT:
RocksDB (6.*) Conan 2 support got merged… let's wait for a more recent version and add it in a follow-up PR, see #46.
EDIT 2:
RocksDB (8.8.1) got merged to conan.io.
EDIT 3:
Uses RocksDB 9.1.0.
NOTE
We can not use Catch2 from conan.io because it is broken: conan-io/conan-center-index#13993