Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NeoForgeSPI dependency #3

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Remove NeoForgeSPI dependency #3

merged 2 commits into from
Mar 28, 2024

Conversation

Technici4n
Copy link
Member

The indirection complicates matters for no benefit.

Requires a major version bump.

See neoforged/FancyModLoader#106 for the corresponding FML PR.

@shartte
Copy link
Contributor

shartte commented Mar 27, 2024

General thoughts: we should use this opportunity to make it clear this is the Coremod Scripting Engine.
As such: ICoreModFile -> ICoreModScriptSource
CoreModEngine -> CoreModScriptingEngine

Thoughts?

@Technici4n
Copy link
Member Author

General thoughts: we should use this opportunity to make it clear this is the Coremod Scripting Engine. As such: ICoreModFile -> ICoreModScriptSource CoreModEngine -> CoreModScriptingEngine

Thoughts?

why not - for a separate PR though. ;)

@shartte
Copy link
Contributor

shartte commented Mar 28, 2024

General thoughts: we should use this opportunity to make it clear this is the Coremod Scripting Engine. As such: ICoreModFile -> ICoreModScriptSource CoreModEngine -> CoreModScriptingEngine
Thoughts?

why not - for a separate PR though. ;)

Thought about this some more: If this PR leads to a breaking change release, shouldn't we actually include all breaking changes since any subsequent breaks would also require a new breaking release? :-P

@shartte shartte self-requested a review March 28, 2024 13:24
@Technici4n Technici4n merged commit 6d03ce5 into main Mar 28, 2024
1 check passed
@Technici4n Technici4n deleted the no-spi branch March 28, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants