Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CoreMods directly instead of going through SPI abstraction #106

Merged
merged 2 commits into from
Mar 31, 2024
Merged

Use CoreMods directly instead of going through SPI abstraction #106

merged 2 commits into from
Mar 31, 2024

Conversation

Technici4n
Copy link
Member

@Technici4n Technici4n commented Mar 27, 2024 •
edited
Loading

Much simpler, and fixes our cyclic SPI -> coremods -> FML dependency. :)

Depends on neoforged/CoreMods#3.

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Mar 27, 2024 •
edited by Technici4n
Loading

  • Publish PR to GitHub Packages

@Technici4n Technici4n mentioned this pull request Mar 27, 2024
Merged
@marchermans marchermans merged commit 4fdb2b4 into neoforged:main Mar 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marchermans marchermans marchermans approved these changes

Assignees
No one assigned
Labels
breaking-change cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Technici4n @marchermans