Allow loading configs from a specified override path #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic for removing the file watch
Shadows-of-Fire
approved these changes
Dec 12, 2023
marchermans
approved these changes
Dec 12, 2023
Technici4n
approved these changes
Dec 12, 2023
shartte
pushed a commit
that referenced
this pull request
Dec 22, 2024
In old startup profiles from 1.19/1.20, `ModuleClassLoader` often takes at least a second or two to be constructed in large modpacks. This likely boils down to the high amounts of iteration being done over the module list - in particular, constructing `parentLoaders` would have O(n^2) runtime in a scenario where every module reads the other modules. This PR makes some changes to the constructor to avoid redundant iteration. I have not profiled the changes, but I don't see a reason why they could be slower than the status quo. In particular, the `parentLoaders` loop has been heavily optimized to cache data for each module, which should provide noticeable speedup to the automatic module case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case is to switch NeoForge server configs from being in the
serverconfigfolder by default to being generated in theconfigfolder, but allowing them to be copy pasted to theserverconfigfolder in the cases users want to have per save overrides for certain values.This PR also simplifies the logic for removing the file watch so that we don't have to determine which location we initially loaded the file from.