Merge core, events, languages subprojects into loader #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technici4n
changed the title
marchermans
approved these changes
Jan 15, 2024
shartte
pushed a commit
that referenced
this pull request
Dec 22, 2024
On ZIP file systems, `Files.isDirectory` ends up being very slow if the path does not exist (similarly to `Files.exists`, which is worked around in UnionFS). We can take advantage of the existing workaround by using our `getFileAttributes` method instead, which attempts to check if the file exists using much more efficient logic. See the profiler screenshot below for an example of the problem. 
shartte
pushed a commit
that referenced
this pull request
Dec 22, 2024
This removes the `ZipFileSystem.exists` hack and implements `FileSystemProvider.readAttributesIfExists` and `FileSystemProvider.exists`. While I was working on this, I also improved the #63 optimization in `readAttributes` by passing already known attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subprojects are separate due to historical reasons, however with the eventbus reworks as well as the SJH serviceloader fixes, we can load all of these subprojects on the MC-BOOTSTRAP layer with no issue.
Tested setups: