Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dead time at 30 Hz #102

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Fix dead time at 30 Hz #102

merged 1 commit into from
Aug 9, 2024

Conversation

mdoucet
Copy link
Member

@mdoucet mdoucet commented Aug 9, 2024

The number of pulses was not counted correctly. Now it is.

@mdoucet mdoucet requested a review from backmari August 9, 2024 17:08
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 44.98%. Comparing base (b432f41) to head (3e042c7).

Files Patch % Lines
..._ui/interfaces/data_handling/DeadTimeCorrection.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #102      +/-   ##
==========================================
+ Coverage   44.96%   44.98%   +0.02%     
==========================================
  Files          33       33              
  Lines        6310     6307       -3     
==========================================
  Hits         2837     2837              
+ Misses       3473     3470       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@backmari backmari merged commit 39ae208 into next Aug 9, 2024
3 checks passed
@backmari backmari deleted the fix-dead-time branch August 9, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants