Replaced macros with constants.

[lewie-donckers]

Replaced all macros with constants.

See https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es31-dont-use-macros-for-constants-or-functions

[Timple]

I'm surprised this passes the build.

Note to self: check why roslint is not active, there should be two spaces before the comment.

[rokusottervanger]

It's an improvement. But more important may be to check why these are constants and not parameters in the first place.

[lewie-donckers]

It's an improvement. But more important may be to check why these are constants and not parameters in the first place.

I suggest you have someone with more domain knowledge than me create an issue about this.

[lewie-donckers]

I'm surprised this passes the build.

Note to self: check why roslint is not active, there should be two spaces before the comment.

Is this something you want fixed?

(I'm not using the clang-format yet.)

[rokusottervanger]

It's an improvement. But more important may be to check why these are constants and not parameters in the first place.

I suggest you have someone with more domain knowledge than me create an issue about this.

You're right. This discussion is already going on in #2 . I'll create an issue about magic numbers in general: #35

[Timple]

Is this something you want fixed?

I want the build to fail on this :).

But yes, please fix as well.

[Rayman]

Nice, constants are definitely much better than macros

[lewie-donckers]

Is this something you want fixed?

I want the build to fail on this :).

But yes, please fix as well.

Fixed by formatting those lines according to the .clang-format file provided by @Timple.