Last minute changes to Coordinator #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emit RitualAuthorityTransferred event
cygnusv
requested review from
vzotova,
derekpierre and
KPrasch
and removed request for
derekpierre
7 tasks
Merged
7 tasks
piotr-roslaniec
approved these changes
Nov 15, 2023
derekpierre
approved these changes
Nov 15, 2023
| initiator_balance_after_refund = erc20.balanceOf(initiator) | ||
| coordinator_balance_after_refund = erc20.balanceOf(coordinator) | ||
| refund = initiator_balance_after_refund - initiator_balance_before_refund | ||
| assert refund == coordinator.getRitualInitiationCost(nodes, ONE_DAY) |
vzotova
reviewed
Nov 15, 2023
| @@ -253,6 +274,7 @@ contract Coordinator is Initializable, AccessControlDefaultAdminRulesUpgradeable | |||
| ritual.endTimestamp = ritual.initTimestamp + duration; | |||
| ritual.accessController = accessController; | |||
|
|
|||
| uint96 minAuthorization = application.minimumAuthorization(); | |||
There was a problem hiding this comment.
I'd suggest to move this variable either to immutable or to variable, each call is slower because of using inner call. I know that is not crucial but would be good to make
vzotova
approved these changes
Nov 15, 2023
| @@ -438,13 +467,14 @@ contract Coordinator is Initializable, AccessControlDefaultAdminRulesUpgradeable | |||
| currency.safeTransferFrom(msg.sender, address(this), ritualCost); | |||
| } | |||
|
|
|||
| function processPendingFee(uint32 ritualId) public { | |||
| function processPendingFee(uint32 ritualId) public returns (uint256) { | |||
There was a problem hiding this comment.
Suggested change
| function processPendingFee(uint32 ritualId) public returns (uint256) { | |
| function processPendingFee(uint32 ritualId) public returns (uint256 refundableFee ) { |
Co-authored-by: Victoria Zotova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
RitualStateto allow discerning active and expired rituals at the protocol state level.Related PRs:
nucypher-contractsnucypher#3344nucypher/taco-web(neenucypher-ts) - Update DKG states based on last minute changes to Coordinator contract. taco-web#398Issues fixed/closed:
Why it's needed:
Notes for reviewers: