-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DKG states based on last minute changes to Coordinator contract. #398
Conversation
✅ Deploy Preview for taco-nft-demo canceled.
|
✅ Deploy Preview for taco-demo canceled.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #398 +/- ##
==========================================
- Coverage 88.01% 88.00% -0.02%
==========================================
Files 33 33
Lines 2704 2700 -4
Branches 232 232
==========================================
- Hits 2380 2376 -4
Misses 293 293
Partials 31 31 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple and effective.
My only pointer here is that the various Ritual states represent a much broader view of the network than makes sense to encapsulate purely in this repo, or even purely as part of TACo. These states apply across our codebases, and also to signing cohorts like the one used by tBTC.
Also: I wonder, why are some states prepended with "DKG_" ? For example, is there a proper state of invalidity (other than, obviously, expired) other than something we'd regard as invalidity of the DKG? Why was "INVALID" insufficient?
These were mimicked from the contract changes - nucypher/nucypher-contracts#187. I believe the thinking here was that some states are part of the DKG process itself (transcripts, aggregations), but once completed successfully (operative word being successful), then using |
Type of PR:
Required reviews:
What this does:
Updates
taco-web
to incorporate latest changes made via nucypher/nucypher-contracts#187.Issues fixed/closed:
Why it's needed:
Notes for reviewers: