Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DKG states based on last minute changes to Coordinator contract. #398

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

derekpierre
Copy link
Member

@derekpierre derekpierre commented Nov 15, 2023

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:

Updates taco-web to incorporate latest changes made via nucypher/nucypher-contracts#187.

Issues fixed/closed:

  • Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on?
Is there a particular commit/function/section of your PR that requires more attention from reviewers?

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for taco-nft-demo canceled.

Name Link
🔨 Latest commit 9720e26
🔍 Latest deploy log https://app.netlify.com/sites/taco-nft-demo/deploys/6557cdf86c3bac0008bfc30b

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for taco-demo canceled.

Name Link
🔨 Latest commit 9720e26
🔍 Latest deploy log https://app.netlify.com/sites/taco-demo/deploys/6557cdf81ef9fe0008e54522

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (202f060) 88.01% compared to head (9720e26) 88.00%.

Files Patch % Lines
packages/taco/src/dkg.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
- Coverage   88.01%   88.00%   -0.02%     
==========================================
  Files          33       33              
  Lines        2704     2700       -4     
  Branches      232      232              
==========================================
- Hits         2380     2376       -4     
  Misses        293      293              
  Partials       31       31              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@derekpierre derekpierre changed the title [WIP] Update DKG states based on last minute changes to Coordinator contract. Update DKG states based on last minute changes to Coordinator contract. Nov 15, 2023
@derekpierre derekpierre marked this pull request as ready for review November 15, 2023 19:20
Copy link

@jMyles jMyles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and effective.

My only pointer here is that the various Ritual states represent a much broader view of the network than makes sense to encapsulate purely in this repo, or even purely as part of TACo. These states apply across our codebases, and also to signing cohorts like the one used by tBTC.

Also: I wonder, why are some states prepended with "DKG_" ? For example, is there a proper state of invalidity (other than, obviously, expired) other than something we'd regard as invalidity of the DKG? Why was "INVALID" insufficient?

@derekpierre
Copy link
Member Author

derekpierre commented Nov 16, 2023

Also: I wonder, why are some states prepended with "DKG_" ? For example, is there a proper state of invalidity (other than, obviously, expired) other than something we'd regard as invalidity of the DKG? Why was "INVALID" insufficient?

These were mimicked from the contract changes - nucypher/nucypher-contracts#187.

I believe the thinking here was that some states are part of the DKG process itself (transcripts, aggregations), but once completed successfully (operative word being successful), then using DKG_ had less meaning because it was no longer really a DKG, but rather had moved passed the DKG process. (perhaps @cygnusv had other thoughts)

@derekpierre derekpierre merged commit f92f9f9 into nucypher:main Nov 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

5 participants