Add BrandIcon component #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/components/BrandIcon.tsx
Outdated
| const iconColor = color ?? theme.color.primary | ||
| const iconSize = size ?? theme.icon.size.large | ||
|
|
||
| return <FontAwesomeIcon icon={icon as IconProp} color={iconColor} size={iconSize} /> |
There was a problem hiding this comment.
Die narrowing as IconProp is verdacht, want de types IconDefinition en IconProp hebben geen expliciete overlap. Als je icon op deze manier definieert dan heb je geen as IconProp nodig:
const { prefix, iconName } = BrandIcons[name]
const icon = { prefix, iconName } as IconLookup(disclaimer: heb niet getest of dit nog steeds goed werkt).
EDIT Weet niet of dit een goede oplossing is, want dit zou ook moeten werken const icon: IconLookup = { prefix, iconName } maar geeft nog steeds typing errors.
There was a problem hiding this comment.
Copilot to the rescue: het was een versieverschil
There was a problem hiding this comment.
Ah! Toch goed gevonden 😉
added 2 commits
January 7, 2025 10:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: https://github.com/observation/obsidentify/pull/990