-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BrandIcon component #60
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
import React from 'react' | ||
|
||
import { IconProp } from '@fortawesome/fontawesome-svg-core' | ||
import { FontAwesomeIcon } from '@fortawesome/react-native-fontawesome' | ||
|
||
import BrandIcons, { BrandIconName } from '../lib/BrandIcons' | ||
import theme from '../styles/theme' | ||
|
||
type Props = { | ||
name: BrandIconName | ||
color?: string | ||
size?: number | ||
} | ||
|
||
const BrandIcon = ({ name, color, size }: Props) => { | ||
const icon = BrandIcons[name] | ||
const iconColor = color ?? theme.color.primary | ||
const iconSize = size ?? theme.icon.size.large | ||
|
||
return <FontAwesomeIcon icon={icon as IconProp} color={iconColor} size={iconSize} /> | ||
} | ||
|
||
export default BrandIcon |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import React from 'react' | ||
|
||
import { render } from '@testing-library/react-native' | ||
|
||
import { theme } from '../../styles' | ||
import BrandIcon from '../BrandIcon' | ||
|
||
describe('BrandIcon', () => { | ||
describe('Rendering', () => { | ||
test('Normal', () => { | ||
const { toJSON } = render(<BrandIcon name="wikipedia-w" />) | ||
expect(toJSON()).toMatchSnapshot() | ||
}) | ||
|
||
test('With color', () => { | ||
const { toJSON } = render(<BrandIcon name="wikipedia-w" color={theme.color.error} />) | ||
expect(toJSON()).toMatchSnapshot() | ||
}) | ||
|
||
test('With size', () => { | ||
const { toJSON } = render(<BrandIcon name="wikipedia-w" size={20} />) | ||
expect(toJSON()).toMatchSnapshot() | ||
}) | ||
}) | ||
}) |
28 changes: 28 additions & 0 deletions
28
src/components/__tests__/__snapshots__/BrandIcon.test.tsx.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
// Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
||
exports[`BrandIcon Rendering Normal 1`] = ` | ||
<Icon | ||
color="#0066B1" | ||
name="wikipedia-w" | ||
size={16} | ||
type="brand" | ||
/> | ||
`; | ||
|
||
exports[`BrandIcon Rendering With color 1`] = ` | ||
<Icon | ||
color="#EA554B" | ||
name="wikipedia-w" | ||
size={16} | ||
type="brand" | ||
/> | ||
`; | ||
|
||
exports[`BrandIcon Rendering With size 1`] = ` | ||
<Icon | ||
color="#0066B1" | ||
name="wikipedia-w" | ||
size={20} | ||
type="brand" | ||
/> | ||
`; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Die narrowing
as IconProp
is verdacht, want de typesIconDefinition
enIconProp
hebben geen expliciete overlap. Als jeicon
op deze manier definieert dan heb je geenas IconProp
nodig:(disclaimer: heb niet getest of dit nog steeds goed werkt).
EDIT Weet niet of dit een goede oplossing is, want dit zou ook moeten werken
const icon: IconLookup = { prefix, iconName }
maar geeft nog steeds typing errors.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot to the rescue: het was een versieverschil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! Toch goed gevonden 😉