Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: Add checks for advanced network options #154

Merged

Conversation

RytoEX
Copy link
Member

@RytoEX RytoEX commented Apr 11, 2024

Description

Add checks for Network Optimizations and TCP Pacing.

Motivation and Context

Detect whether the user has set these options without having to dig through the log manually. Emit an INFO message since this is typically not critical.

How Has This Been Tested?

Tested locally on Windows 11.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@RytoEX RytoEX added the enhancement New feature or request label Apr 11, 2024
@RytoEX RytoEX requested a review from Fenrirthviti April 11, 2024 21:36
@RytoEX RytoEX self-assigned this Apr 11, 2024
Copy link
Member

@Fenrirthviti Fenrirthviti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the nits, looks good to me.

checks/network.py Outdated Show resolved Hide resolved
checks/network.py Outdated Show resolved Hide resolved
Add checks for Network Optimizations and TCP Pacing.
@RytoEX RytoEX force-pushed the add-network-optimization-detection branch from c54b091 to 50c908d Compare April 12, 2024 22:22
@RytoEX RytoEX requested a review from Fenrirthviti April 13, 2024 00:04
@Fenrirthviti Fenrirthviti merged commit bbec7cc into obsproject:master Apr 13, 2024
2 checks passed
@RytoEX RytoEX deleted the add-network-optimization-detection branch April 14, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants