Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: Add checks for advanced network options #154

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions checks/network.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,20 @@ def checkDynamicBitrate(lines):
return None


def checkNetworkOptimizations(lines):
networkOptimizationLines = search('New socket loop enabled by user', lines)
if (len(networkOptimizationLines) > 0):
return [LEVEL_INFO, "Network Optimizations", "Network Optimizations are enabled. This option is disabled by default. It is only suggested to enable Network Optimizations if you are having issues streaming. The setting can be toggled in Settings -> Advanced -> Network."]
return None


def checkTCPPacing(lines):
TCPPacingLines = search('Low latency mode enabled by user', lines)
if (len(TCPPacingLines) > 0):
return [LEVEL_INFO, "TCP Pacing", "TCP Pacing (Low Latency mode) is enabled. This option is disabled by default. It is only suggested to enable TCP Pacing if you are having issues streaming. The setting can be toggled in Settings -> Advanced -> Network."]
return None


def checkStreamDelay(lines):
delayLines = search('second delay active', lines)
if (len(delayLines) > 0):
Expand Down
2 changes: 2 additions & 0 deletions loganalyzer.py
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,8 @@ def doAnalysis(url=None, filename=None):
checkWin10Hags(logLines),
checkNICSpeed(logLines),
checkDynamicBitrate(logLines),
checkNetworkOptimizations(logLines),
checkTCPPacing(logLines),
checkStreamDelay(logLines),
checkUnknownEncoder(logLines),
checkBrowserSource(logLines),
Expand Down