Parallelize the set command #33
Conversation
dominikl
force-pushed
the
parallelize_set
branch
from
86bc15c to
c5cd1e0
Compare
src/omero_cli_render.py
Outdated
| img.setDefaultZ(def_z - 1) | ||
| if def_t: | ||
| img.setDefaultT(def_t - 1) | ||
| if args.batch > 1: |
There was a problem hiding this comment.
I could imagine using the futures method even if the batch is 1 to keep things simpler.
src/omero_cli_render.py
Outdated
| iid = future.result() | ||
| iids.append(iid) | ||
| except Exception as exc: | ||
| print('%d generated an exception: %s' % (img.id, |
There was a problem hiding this comment.
This should be a call to self.ctx.err (or possibly ctx.out if there's nothing on stdout that anyone might use).
src/omero_cli_render.py
Outdated
| for img in self.load_images(self.gateway, args.object, batch=1): | ||
| iid = self._set_rend(args, data, img, cindices, greyscale, | ||
| rangelist, colorlist) | ||
| iids.append(iid) | ||
|
|
||
| if not iids: | ||
| self.ctx.die(113, "ERROR: No images found for %s %d" % |
There was a problem hiding this comment.
Perhaps also use self.ctx.die (with a different error number?) if any exceptions are thrown.
| @@ -414,7 +420,7 @@ def _lookup(self, gateway, type, oid): | |||
| self.ctx.die(110, "No such %s: %s" % (type, oid)) | |||
| return obj | |||
|
|
|||
| def render_images(self, gateway, object, batch=100): | |||
| def load_images(self, gateway, object, batch=100): | |||
There was a problem hiding this comment.
Can you explain your thoughts on this rename?
There was a problem hiding this comment.
Because the method doesn't render any images, it just loads the images. I found the name render_images totally confusing every time I looked into the omero_cli_render code.
| @@ -396,6 +397,11 @@ def _configure(self, parser): | |||
| help="Local file or OriginalFile:ID which specifies the " | |||
| "rendering settings") | |||
|
|
|||
| set_cmd.add_argument( | |||
| "--batch", type=int, default=1, | |||
There was a problem hiding this comment.
Have you considered a higher default?
There was a problem hiding this comment.
Could do. Just didn't want to change the default behaviour if the new option is omitted.
|
Wait for #34 to be merged. |
Adds a
--batchoption to the set command.Test:
Get rendering settings from an image:
Then apply it to a whole Dataset, Project or whatever (with compatible images).
Example:
Needs ome/omero-py#129 to work.