-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
render set: helper refactoring #34
Conversation
Conflicting PR. Removed from build OMERO-plugins-push#101. See the console output for more details.
|
Looks good. Just one comment (see above), and when I ran it, got a warning:
Edit: The warning doesn't have anything to do with the PR though, seems to be a python3 thing. |
Tested again, works. Good to merge 👍 |
While working on a feature allowing to process multiple images with multiple rendering settings, I found it useful to refactor the logic of the
render set
command dealing with loading and parsing rendering settings from a source (object or file on disk).The changes included in this PR should not changing behavior, include some cleanup (
print
->debug
) as well as unit tests starting to cover some of the individual functionalities