Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP ✨ Record the generation start and applied time for manifestwork #780

Closed

Conversation

zhujian7
Copy link
Member

Summary

Related issue(s)

Fixes #

Copy link
Contributor

openshift-ci bot commented Dec 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 17.35537% with 100 lines in your changes missing coverage. Please review.

Project coverage is 63.47%. Comparing base (e1b5f88) to head (aae012a).

Files with missing lines Patch % Lines
...ollers/timestampcontroller/timestamp_controller.go 9.90% 100 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #780      +/-   ##
==========================================
- Coverage   63.77%   63.47%   -0.31%     
==========================================
  Files         192      193       +1     
  Lines       18596    18717     +121     
==========================================
+ Hits        11860    11881      +21     
- Misses       5756     5856     +100     
  Partials      980      980              
Flag Coverage Δ
unit 63.47% <17.35%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhujian7 zhujian7 force-pushed the work-generation-time branch from a949476 to c578383 Compare December 25, 2024 13:20
@zhujian7 zhujian7 force-pushed the work-generation-time branch from 1c7e5cb to 2bb8a1f Compare December 25, 2024 14:09
@@ -0,0 +1,188 @@
package timestampcontroller

import (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add this in the metrics-collector instead of here?

@zhujian7
Copy link
Member Author

zhujian7 commented Jan 2, 2025

/close

@openshift-ci openshift-ci bot closed this Jan 2, 2025
Copy link
Contributor

openshift-ci bot commented Jan 2, 2025

@zhujian7: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants