-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP ✨ Record the generation start and applied time for manifestwork #780
WIP ✨ Record the generation start and applied time for manifestwork #780
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #780 +/- ##
==========================================
- Coverage 63.77% 63.47% -0.31%
==========================================
Files 192 193 +1
Lines 18596 18717 +121
==========================================
+ Hits 11860 11881 +21
- Misses 5756 5856 +100
Partials 980 980
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: zhujian <[email protected]>
a949476
to
c578383
Compare
Signed-off-by: zhujian <[email protected]>
1c7e5cb
to
2bb8a1f
Compare
Signed-off-by: zhujian <[email protected]>
@@ -0,0 +1,188 @@ | |||
package timestampcontroller | |||
|
|||
import ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we add this in the metrics-collector instead of here?
/close |
@zhujian7: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary
Related issue(s)
Fixes #