Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment of the RecordOnly sampling decision #6257

Merged
merged 6 commits into from
Feb 6, 2025

Conversation

XSAM
Copy link
Member

@XSAM XSAM commented Feb 5, 2025

No description provided.

@XSAM XSAM added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 5, 2025
@XSAM XSAM added this to the v1.35.0 milestone Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.8%. Comparing base (51cf2d7) to head (a003c80).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6257   +/-   ##
=====================================
  Coverage   81.8%   81.8%           
=====================================
  Files        283     283           
  Lines      24892   24892           
=====================================
+ Hits       20380   20381    +1     
+ Misses      4108    4107    -1     
  Partials     404     404           

see 1 file with indirect coverage changes

sdk/trace/sampling.go Outdated Show resolved Hide resolved
sdk/trace/sampling.go Outdated Show resolved Hide resolved
sdk/trace/sampling.go Show resolved Hide resolved
sdk/trace/sampling.go Show resolved Hide resolved
@MrAlias MrAlias merged commit d46bfb0 into open-telemetry:main Feb 6, 2025
32 checks passed
@XSAM XSAM deleted the fix-incorrect-comment branch February 6, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants