Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment of the RecordOnly sampling decision #6257

Merged
merged 6 commits into from
Feb 6, 2025
Merged

Fix comment of the RecordOnly sampling decision #6257

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1e79de5
Fix comment of the RecordOnly sampling decision
XSAM Feb 5, 2025
668fd95
Drop markdown syntax
XSAM Feb 5, 2025
2d81423
Merge branch 'main' into fix-incorrect-comment
XSAM Feb 5, 2025
1fc69c7
Fix format
XSAM Feb 5, 2025
c0da2f4
Consistent capitalization style
XSAM Feb 5, 2025
a003c80
Merge branch 'main' into fix-incorrect-comment
MrAlias Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/trace/sampling.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,11 @@ const (
// Drop will not record the span and all attributes/events will be dropped.
Drop SamplingDecision = iota

// RecordOnly indicates the span's `IsRecording() == true`, but `Sampled` flag
// RecordOnly indicates the span's IsRecording method returns true, but [trace.FlagsSampled] flag
XSAM marked this conversation as resolved.
Show resolved Hide resolved
// *must not* be set.
RecordOnly

// RecordAndSample has span's `IsRecording() == true` and `Sampled` flag
// RecordAndSample indicates the span's IsRecording method returns true and [trace.FlagsSampled] flag
// *must* be set.
RecordAndSample
)
Expand Down
Loading