[1.2] libct/cg/sd: set the DeviceAllow property before DevicePolicy #4615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every unit created by runc need daemon reload since systemd v230. This breaks support for NVIDIA GPUs, see opencontainers#3708 (comment) A workaround is to set DeviceAllow before DevicePolicy. Also: - add a test case (which fails before the fix) by @kolyshkin - better explain why we need empty DeviceAllow (by @cyphar) Fixes 4568. Reported-by: Jian Wen <[email protected]> Co-authored-by: Jian Wen <[email protected]> Co-authored-by: Aleksa Sarai <[email protected]> Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit d84388a) Signed-off-by: Kir Kolyshkin <[email protected]>
xximwon
approved these changes
Feb 6, 2025
|
No longer a draft. |
kolyshkin
requested review from
rata,
lifubang,
thaJeztah,
cyphar and
AkihiroSuda
xximwon
approved these changes
Feb 7, 2025
xximwon
approved these changes
Feb 7, 2025
cyphar
approved these changes
Feb 7, 2025
AkihiroSuda
approved these changes
Feb 7, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A backport of #4612 to release-1.2.
Draft until that one is merged.Original description follows.Every unit created by runc need daemon reload since systemd v230. This breaks support for NVIDIA GPUs, see
#3708 (comment)
A workaround is to set DeviceAllow before DevicePolicy.
Also:
Fixes 4568.
Reported-by: Jian Wen [email protected]
(cherry picked from commit d84388a)