Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update mongodb binary version to 6 #8032

Merged
merged 1 commit into from
Jan 7, 2025
Merged

fix: update mongodb binary version to 6 #8032

merged 1 commit into from
Jan 7, 2025

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Jan 7, 2025 •
edited
Loading

Problem

Our builds are failing as ubuntu-latest utilised by our Github runners are getting updated. This switches ubuntu-latest from 22.04 to 24.04 which changes some underlying libraries.

One of the the key libraries is openssl which is updated from v1 to v3 as v1 is no longer maintained by the openssl team. Consequently, MongoDB v4 uses openssl1 which causes the failure of our build.

Solution

  1. Update MonogDB binary version[1] to v6, which is what we're utilising.
  2. Update mongodb-memory-server-core to its latest minor version. Just taking the opportunity to bump this.

[1] MONGO_BINARY_VERSION is only utilised by our test runners where it runs a mongodbserver on localhost.

Breaking Changes

  • No - this PR is backwards compatible

@KenLSM KenLSM requested a review from kevin9foong January 7, 2025 07:27
@datadog-opengovsg
Copy link

Datadog Report

Branch report: fix/monogodb-server-failure
Commit report: d033bb5
Test service: formsg

✅ 0 Failed, 1465 Passed, 0 Skipped, 3m 51.11s Total duration (1h 23m 36.03s time saved)

@KenLSM KenLSM requested a review from scottheng96 January 7, 2025 07:46
@scottheng96 scottheng96 merged commit a202c57 into develop Jan 7, 2025
24 checks passed
@scottheng96 scottheng96 deleted the fix/monogodb-server-failure branch January 7, 2025 08:03
@KenLSM KenLSM mentioned this pull request Jan 7, 2025
Merged
4 tasks
KenLSM added a commit that referenced this pull request Jan 8, 2025
@KenLSM @dependabot
@siddarth2824 @LoneRifle
Merge pull request #8027 from opengovsg/release_v6.173.0
2d36463 
* fix(deps): bump fp-ts from 2.16.8 to 2.16.9 (#8017)

Bumps [fp-ts](https://github.com/gcanti/fp-ts) from 2.16.8 to 2.16.9.
- [Release notes](https://github.com/gcanti/fp-ts/releases)
- [Changelog](https://github.com/gcanti/fp-ts/blob/master/CHANGELOG.md)
- [Commits](https://github.com/gcanti/fp-ts/commits/2.16.9)

---
updated-dependencies:
- dependency-name: fp-ts
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: multi lang feature (#8022)

* feat: add model fields to represent translations for form fields (#7457)

* feat: add fields in model to represent translations for form fields

* feat: add shared types to represent form field translations

* fix: use unicode locales

* feat: add settings tab and toggle for multi lang feature (#7561)

* feat: add settings tab and toggle for multi lang feature

* feat: add fields to joi validations

* fix: refactor code to address comments

* fix: failing tests

* feat: add tooltip over icons

* feat: add chromatic tests

* feat: add form field list for translation (#7778)

* feat: add model fields to represent translations for form fields (#7457)

* feat: add fields in model to represent translations for form fields

* feat: add shared types to represent form field translations

* fix: use unicode locales

* feat: add settings tab and toggle for multi lang feature (#7561)

* feat: add settings tab and toggle for multi lang feature

* feat: add fields to joi validations

* fix: refactor code to address comments

* fix: failing tests

* feat: add tooltip over icons

* feat: add chromatic tests

* feat: add view to list form fields for translation

* feat: update logic for checking completion of translations and add storybook tests

* chore: uncomment growthbook middleware usage

* chore: update storybook function used

* chore: address comments

* chore: update app router

* feat: add view for translation input (#7895)

* feat: add view for translation input

* fix: refactor code and remove console log statements

* chore: clean up code

* chore: fix alignment of translation input and header

* chore: address comments

* feat: add translations to public form (#7976)

* feat: add model fields to represent translations for form fields (#7457)

* feat: add fields in model to represent translations for form fields

* feat: add shared types to represent form field translations

* fix: use unicode locales

* feat: add settings tab and toggle for multi lang feature (#7561)

* feat: add settings tab and toggle for multi lang feature

* feat: add fields to joi validations

* fix: refactor code to address comments

* fix: failing tests

* feat: add tooltip over icons

* feat: add chromatic tests

* feat: add translations on public form

* fix: missing provider values for preview and template providers

* feat: add fixed translations for yes and no field

* chore: fix code

* chore: remove unused code and add import

* feat: add fixed translations for est time taken string

* chore: remove unnecessary loggin

* feat: add translations for verifiable fields

* chore: fix tests

* feat: add error if user adds less than required translations for form fields with options

* feat: add beta flag for multi language translation feature for admins

* chore: refactor code

* feat: add fixed translations for default placeholders on public form

* feat: add fixed translations for not found label

* feat: add translations for maximum file size label

* feat: add translations for others label

* feat: add fixed translations for add row label

* feat: add translation for prevent submission messages

* fix: make prevent submission translations optional

* fix: tests

* refactor: use i18next to toggle languages

Use i18next to hold currently selected language rather than use our own
internal state flag in PublicFormContext. That way, a form submitter
can control the language used across the entire Form service.

- Rework LanguageControl and PublicFormContext to use i18next to hold
  currently selected language, falling back on `Language.ENGLISH`
- Rework components to lookup current lang from `useTranslation()`, not
  `PublicFormContext.selectedPublicFormLanguage` or prop passing

* fix: stub i18next for YesNo,Email,Verify fields

* refactor(i18n): move translations from `fixedTranslations`

* refactor(i18n): extract hard-coded translations

* feat: add title translations for MyInfo fields

* feat: always default language back to English on CreatePage

* fix: update myInfo translations and address comments

* feat: add custom header to track user selected form language

---------

Co-authored-by: LoneRifle <[email protected]>

---------

Co-authored-by: LoneRifle <[email protected]>

* fix: update mongodb binary version to 6 (#8032)

* chore: bump version to v6.173.0

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Siddarth Nandanahosur Suresh <[email protected]>
Co-authored-by: LoneRifle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottheng96 scottheng96 scottheng96 approved these changes

@kevin9foong kevin9foong Awaiting requested review from kevin9foong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KenLSM @scottheng96