Increase fetch.min.bytes to 64kb for kafka buffer consumer #5378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graytaylor0
requested review from
sb2k16,
chenqi0805,
engechas,
san81,
srikanthjg,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
kkondaka
previously approved these changes
Jan 31, 2025
sb2k16
previously approved these changes
Jan 31, 2025
Signed-off-by: Taylor Gray <[email protected]>
dlvenable
reviewed
Jan 31, 2025
| @@ -27,7 +27,7 @@ class BufferTopicConfig extends CommonTopicConfig implements TopicProducerConfig | |||
| static final boolean DEFAULT_AUTO_COMMIT = false; | |||
| static final ByteCount DEFAULT_FETCH_MAX_BYTES = ByteCount.parse("50mb"); | |||
| static final Duration DEFAULT_FETCH_MAX_WAIT = Duration.ofMillis(1000); | |||
| static final ByteCount DEFAULT_FETCH_MIN_BYTES = ByteCount.parse("2kb"); | |||
| static final ByteCount DEFAULT_FETCH_MIN_BYTES = ByteCount.parse("64kb"); | |||
There was a problem hiding this comment.
Why not change for the source as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increases fetch.min.bytes to 64kb for kafka buffer consumer
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.